devcontainer: fix Authorization header not passed to PHP via Apache#60737
Closed
Jay-1409 wants to merge 16 commits into
Closed
devcontainer: fix Authorization header not passed to PHP via Apache#60737Jay-1409 wants to merge 16 commits into
Jay-1409 wants to merge 16 commits into
Conversation
Jay-1409
requested review from
artonge,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
iconv transliteration is locale- and config-dependent and fails silently on some setups. UnicodeString::ascii() from symfony/string uses a built-in transliteration table backed by symfony/polyfill-intl-normalizer, so it works on all setups without requiring optional PHP extensions. Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com> Signed-off-by: Jay Shah <jay_shah@outlook.in>
…olower Followup to nextcloud#59646: guard against null reaching strtolower() in both AppConfig and UserConfig getValueBool(). Also aligns AppConfig with the (string) cast added in UserConfig by the original PR. Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: Jay Shah <jay_shah@outlook.in>
Bumps the eslint group with 1 update in the / directory: [eslint](https://github.com/eslint/eslint). Updates `eslint` from 10.3.0 to 10.4.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v10.3.0...v10.4.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.4.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: eslint ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Jay Shah <jay_shah@outlook.in>
Bumps [qs](https://github.com/ljharb/qs) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together. Updates `qs` from 6.14.2 to 6.15.2 - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.14.2...v6.15.2) Updates `express` from 4.22.1 to 4.22.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/v4.22.2/History.md) - [Commits](expressjs/express@v4.22.1...v4.22.2) --- updated-dependencies: - dependency-name: qs dependency-version: 6.15.2 dependency-type: indirect - dependency-name: express dependency-version: 4.22.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Jay Shah <jay_shah@outlook.in>
Signed-off-by: Jay shah <166749819+Jay-1409@users.noreply.github.com> Signed-off-by: Jay Shah <jay_shah@outlook.in>
Bumps [webdav](https://github.com/perry-mitchell/webdav-client) from 5.9.0 to 5.10.0. - [Changelog](https://github.com/perry-mitchell/webdav-client/blob/master/CHANGELOG.md) - [Commits](perry-mitchell/webdav-client@v5.9.0...v5.10.0) --- updated-dependencies: - dependency-name: webdav dependency-version: 5.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Jay Shah <jay_shah@outlook.in>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: Jay Shah <jay_shah@outlook.in>
Adds an NcDialog confirmation to the Revoke action; deletion was previously instant on click. When the token is marked for remote wipe, the dialog surfaces a warning and the destructive button switches to "Cancel wipe and revoke" so cancelling an in-flight wipe is an explicit opt-in. Also migrates the existing Wipe confirm from the legacy window.OC.dialogs.confirm helper to NcDialog, matching the new delete dialog. The auth token store actions are now pure API callers; the UI does the gating. Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com> Signed-off-by: Jay Shah <jay_shah@outlook.in>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com> Signed-off-by: Jay Shah <jay_shah@outlook.in>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com> Signed-off-by: Jay Shah <jay_shah@outlook.in>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com> Signed-off-by: Jay Shah <jay_shah@outlook.in>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com> Signed-off-by: Jay Shah <jay_shah@outlook.in>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com> Signed-off-by: Jay Shah <jay_shah@outlook.in>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com> Signed-off-by: Jay Shah <jay_shah@outlook.in>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Jay Shah <jay_shah@outlook.in>
Jay-1409
requested review from
a team,
SebastianKrupinski and
hamza221
as code owners
Contributor
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the devcontainer setup by fixing an issue where Apache was not forwarding the Authorization header to PHP, which could break authentication flows inside the container.
It adds an Apache configuration during devcontainer setup that ensures the Authorization header is correctly passed through to PHP using SetEnvIfNoCase. The config is automatically enabled via a2enconf.
This resolves authentication issues in the Docker/devcontainer environment where tokens or auth headers were previously being stripped, ensuring consistent login and API behavior during local development.
3. to review, feature component)stable32)AI (if applicable)